Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add create instance to generator #122 #128

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Add create instance to generator #122 #128

merged 1 commit into from
Jun 10, 2024

Conversation

bwalkerl
Copy link
Contributor

Closes #122

\component_generator_base was swapped to testing_module_generator to match generators in other mod classes and provide access to the parent create_instance() method.

Ideally typeid would be set up properly and match the other examples using something like create_cms_type(['datasources' => 'fields']), but this was causing cache key errors within test_delete_module_delete_events so I went with the minimal implementation to resolve the current issue.

@dmitriim dmitriim merged commit 9bc6456 into main Jun 10, 2024
28 checks passed
@dmitriim dmitriim deleted the add-create-instance branch June 10, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Call to undefined method mod_cms_generator::create_instance()
2 participants